GNOME Shell Extensions

Review of "Run or raise" version 47 (45)

Details Page Preview

Run or raise

by e2rd

Launch or focus the window or define custom shortcuts in a text file

Extension Homepage
https://github.com/CZ-NIC/run-or-raise
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:171 
    accelerator.connect()

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json 
    shell-version=['45', '46', '47', '48', '49', '50', '51']

All Versions

Version Status
49 (47) Active
48 (46) Active
47 (45) Rejected
46 (44) Active
45 (43) Active
44 (42) Active
41 Active
40 Active
39 Inactive
38 Active
37 Active
36 Rejected
35 Rejected
34 Active
33 Inactive
32 Active
31 Active
30 Active
29 Active
28 Active
27 Active
26 Rejected
25 Active
24 Active
23 Active
22 Rejected
21 Rejected
20 Rejected
19 Rejected
18 Rejected
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Inactive
10 Active
9 Active
8 Rejected
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Timeout should be removed on destroy and before creating a new one (line 366, 384 `lib/action.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources) 2. Calling `stop()` (line 317 `lib/action.js`) like that isn't enough. You should create `Action.destroy()` method and call it in disable function. To make the cleanup process easier in `Action` class, you can use `connectObject()` and `disconnectObject()`.