EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

• syncthing.js:992

  systemDConfigFileFrom.load_contents(null)

• utils.js:38

  this.#file.load_contents(null)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 17 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

• syncthing.js:639

  console.warn(LOG_PREFIX, "event processing failed", error.message)

• syncthing.js:725

  console.warn(LOG_PREFIX, "refresh error", error.message)

• syncthing.js:822

        console.warn(
          LOG_PREFIX,
          "failed to check pending requests",
          error.message,
        )

• syncthing.js:959

  console.warn(LOG_PREFIX, "which syncthing failed", error.message)

• syncthing.js:1017

            console.warn(
              LOG_PREFIX,
              "couldn't write systemd configuration file to " +
                systemDConfigFileTo,
            )

• syncthing.js:1024

          console.warn(
            LOG_PREFIX,
            "couldn't write systemd configuration file to " +
              systemDConfigFileTo,
            error.message,
          )

• syncthing.js:1046

          console.warn(
            LOG_PREFIX,
            "systemd call failed, switching to API only mode",
          )

• syncthing.js:449

  console.error(LOG_PREFIX, "service change error", error)

• syncthing.js:605

            console.error(
              LOG_PREFIX,
              Error.SERVICE,
              event.data.error,
              event.data.when,
            )

• syncthing.js:781

  console.error(LOG_PREFIX, Error.SERVICE, errors[i])

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• extension.js:27

      this.settings.connect("changed", () => {
        this._settingTimer.run(() => {
          this.indicator.close();
          this.disable();
          this.enable();
        });
      })

• syncthing.js:258

        folder.connect(
          Signal.STATE_CHANGE,
          this.determineStateDelayed.bind(this),
        )

• syncthing.js:257

      this.folders.connect(Signal.ADD, (collection, folder) => {
        folder.connect(
          Signal.STATE_CHANGE,
          this.determineStateDelayed.bind(this),
        );
      })

• syncthing.js:310

      this._manager.connect(Signal.DEVICE_ADD, (manager, device) => {
        device.connect(
          Signal.STATE_CHANGE,
          this.determineStateDelayed.bind(this),
        );
      })

• syncthing.js:311

        device.connect(
          Signal.STATE_CHANGE,
          this.determineStateDelayed.bind(this),
        )

• syncthing.js:317

        device.connect(
          Signal.STATE_CHANGE,
          this.determineStateDelayed.bind(this),
        )

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

• prefs.js:27

  this._i18n = new Utils.I18N(this, gettext)