EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

• schemas/gschemas.compiled

  schemas/gschemas.compiled

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

• formatters/01_luxon.js
• formatters/02_original.js
• formatters/03_swatch.js
• lib/SimpleDateFormat.js
• lib/luxon.js

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• extension.js:262

  this.localTimeFileMonitor.connect('changed',()=>this._onSettingsChange())

EGO-L-007 warning

main loop sources should be removed before being recreated

Main loop sources should be removed before creating a new source on the same field.

Remove main loop sources

• extension.js:303

          this._timerId = GLib.timeout_add(EVERY.priority, EVERY.timeout, () =>
            this.update()
          )

EGO-C45-001 warning

45+ preferences should use fillPreferencesWindow instead of getPreferencesWidget

45+ preferences code should use `fillPreferencesWindow()` instead of `getPreferencesWidget()`.

Preferences

• prefs.js:565

    getPreferencesWidget() {
      const frame = new Gtk.Box()
      const widget = new Preferences(this.getSettings())
      addBox(frame, widget.main)
      if (frame.show_all) frame.show_all()
      return frame
    }