Review of "Quick Lofi" version 23

Details Page Preview

Play lofi music and other sounds, locally or online, on your GNOME desktop with just a click! You need MPV for this extension to work. Fedora: sudo dnf install mpv Ubuntu: sudo apt install mpv Arch Linux: sudo pacman -S mpv Optional click actions can copy the radio URL to the clipboard.

Extension Homepage
https://quick-lofi.eucaue.online/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3 manual_review 1

Shexli found 4 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • modules/ClickActions.js:49
    St.Clipboard.get_default()

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • modules/Indicator.js:370
    this._scrollView = new St.ScrollView()

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • modules/Indicator.js:370
    this._scrollView = new St.ScrollView()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • modules/Indicator.js:66
            this.menu.connect('open-state-changed', (_menu, open) => {
                this._handlePopupSize();
                if (open)
                    statusTooltip.hide();
            })

All Versions

Version Status
27 Active
26 Rejected
25 Rejected
24 Active
23 Rejected
22 Active
21 Rejected
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Rejected
7 Rejected
6 Active
5 Rejected
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

Caue auto- rejected
Auto-rejected because of new version 24 was uploaded