Play lofi music and other sounds, locally or online, on your GNOME desktop with just a click! You need MPV for this extension to work. Fedora: sudo dnf install mpv Ubuntu: sudo apt install mpv Arch Linux: sudo pacman -S mpv Optional click actions can copy the radio URL to the clipboard.
Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
EGO-A-005 manual_review
extensions should not access the clipboard directly
Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.
Quick Lofi
modules/ClickActions.js:49
St.Clipboard.get_default()
EGO-L-002 warning
objects created by extension should be destroyed in disable()
Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.
modules/Indicator.js:372
this._scrollView = new St.ScrollView()
EGO-L-005 warning
owned object references should be released in disable()
Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.
modules/Indicator.js:372
this._scrollView = new St.ScrollView()
EGO-L-003 warning
signals connected by extension should be disconnected in disable()
Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.
modules/Indicator.js:68
this.menu.connect('open-state-changed', (_menu, open) => {
this._handlePopupSize();
if (open)
statusTooltip.hide();
})
| Version | Status |
|---|---|
| 27 | Active |
| 26 | Rejected |
| 25 | Rejected |
| 24 | Active |
| 23 | Rejected |
| 22 | Active |
| 21 | Rejected |
| 20 | Active |
| 19 | Active |
| 18 | Active |
| 17 | Active |
| 16 | Active |
| 15 | Active |
| 14 | Active |
| 13 | Active |
| 12 | Active |
| 11 | Active |
| 10 | Active |
| 9 | Active |
| 8 | Rejected |
| 7 | Rejected |
| 6 | Active |
| 5 | Rejected |
| 4 | Active |
| 3 | Active |
| 2 | Rejected |
| 1 | Rejected |
Hey! :) Version 25 adds GNOME 45 support, a configurable fade when stopping or switching radios, and YouTube search in the Radios preferences. In src/, tests/ and schemas/, the diff has 799 additions and 73 deletions across 28 files. Is this amount okay for review, or would you prefer a smaller diff? Release notes for v1.10.0: https://github.com/EuCaue/gnome-shell-extension-quick-lofi/releases/tag/v1.10.0
Sorry, I got the diff numbers wrong earlier. The actual diff between versions 24 and 25 is 517 additions and 61 deletions across 21 files. It doesn't include tests. :D
Timeout should be removed on disable and before creating a new one (line 8 `preferences/Subprocess.js`): [EGO Review Guidelines: Timeout](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources)