EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

• files.js:568

  this.file.load_contents(null)

• files.js:637

  this.file.load_contents(null)

• files.js:566

  this.file.load_bytes(null)

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

• menu.js:996

          this.clearIcon = new St.Icon({
              style_class: 'search-entry-icon',
              icon_name: 'edit-clear-symbolic'
          })

• menu.js:981

          this.entry = new St.Entry({
              hint_text: params.hint_text || "",
              style_class: 'search-entry draw-on-gnome-menu-entry',
              track_hover: true,
              reactive: true,
              can_focus: true,
              x_expand: true
          })

• menu.js:974

          this.item = new PopupMenu.PopupBaseMenuItem({ style_class: 'draw-on-gnome-menu-entry-item',
                                                        activate: false,
                                                        reactive: true,
                                                        can_f

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

• menu.js:996

          this.clearIcon = new St.Icon({
              style_class: 'search-entry-icon',
              icon_name: 'edit-clear-symbolic'
          })

• menu.js:981

          this.entry = new St.Entry({
              hint_text: params.hint_text || "",
              style_class: 'search-entry draw-on-gnome-menu-entry',
              track_hover: true,
              reactive: true,
              can_focus: true,
              x_expand: true
          })

• menu.js:974

          this.item = new PopupMenu.PopupBaseMenuItem({ style_class: 'draw-on-gnome-menu-entry-item',
                                                        activate: false,
                                                        reactive: true,
                                                        can_f

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• extension.js:122

  this._indicator.toggle.connect('clicked', this._onToggleClicked.bind(this))

• menu.js:994

  this.entry.clutter_text.connect('activate', this._onTextActivated.bind(this))

• menu.js:1000

  this.entry.connect('secondary-icon-clicked', this._reset.bind(this))

• menu.js:993

  this.entry.clutter_text.connect('text-changed', this._onTextChanged.bind(this))