Review of "Customised Workspaces" version 79

Details Page Preview

Customised Workspaces enables creating isolated and customised workspaces. * Choose a different background image for each workspace * Your dash will have unique favourite applications on each workspace * Optionally isolate running applications to only appear on the dash in their respective workspace * Optionally show workspace information and actions in the overview * Set each customised workspace to autoload on specific workspaces * Hide the extension once you've configured your preferences to enjoy seamlessly upgraded workspaces in gnome shell Please do not leave a comment for issues and instead report it here: https://github.com/blipk/Customised-Workspaces/issues

Extension Homepage
https://github.com/blipk/Customised-Workspaces

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-006 warning

extensions should not use lookupByURL or lookupByUUID for current extension access

Use `this`, `this.getSettings()` or `this.path` instead of `lookupByURL()` or `lookupByUUID()` for the current extension.

`extensionUtils`

  • extension.js:73
    Extension.lookupByUUID( DASH_TO_PANEL_UUID )
  • extension.js:92
    Extension.lookupByUUID( DASH_TO_DOCK_UUID )

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • fileUtils.js:208
    file.load_contents( null )
  • inputValidator.js:596
    file.load_contents( null )
  • workspaceManager.js:230
    envFile.load_contents( null )

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • lib/ui/appChooser.js

All Versions

Previous Reviews on this Version

JustPerfection rejected
line 302, 316 `utils.js`: https://gjs.guide/extensions/review-guidelines/best-practices.html#avoid-unnecessary-try-catch-wrappers
k-extd posted a review
That page is only a warning, it says "avoid", not "absolutely will this get your extension rejected" ??? Besides the try/catch wrap on every function was done long before LLMs and was necessary because earlier versions of gnome shell and gjs would swallow and lose errors in strange ways, as well as endless crashes and memory consumption with gnome-logs, and the inaccessibility of looking glass.
JustPerfection posted a review
Please remove them. You shouldn't use try-catch for disconnect.