Review of "Customised Workspaces" version 78

Details Page Preview

Customised Workspaces enables creating isolated and customised workspaces. * Choose a different background image for each workspace * Your dash will have unique favourite applications on each workspace * Optionally isolate running applications to only appear on the dash in their respective workspace * Optionally show workspace information and actions in the overview * Set each customised workspace to autoload on specific workspaces * Hide the extension once you've configured your preferences to enjoy seamlessly upgraded workspaces in gnome shell Please do not leave a comment for issues and instead report it here: https://github.com/blipk/Customised-Workspaces/issues

Extension Homepage
https://github.com/blipk/Customised-Workspaces

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 5

Shexli found 5 issues that may need reviewer attention.

EGO-X-006 warning

extensions should not use lookupByURL or lookupByUUID for current extension access

Use `this`, `this.getSettings()` or `this.path` instead of `lookupByURL()` or `lookupByUUID()` for the current extension.

`extensionUtils`

  • extension.js:73
    Extension.lookupByUUID( "dash-to-panel@jderose9.github.com" )
  • extension.js:91
    Extension.lookupByUUID( "dash-to-dock@micxgx.gmail.com" )

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • fileUtils.js:190
    file.load_contents( null )
  • inputValidator.js:558
    file.load_contents( null )
  • workspaceManager.js:231
    envFile.load_contents( null )

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • lib/ui/appChooser.js

EGO-L-001 warning

extension must not create GObject instances or modify shell before enable()

Resource creation or signal/source setup was found outside `enable()`.

Only use initialization for static resources

  • workspaceIsolater.js:32
    AppSystem = Shell.AppSystem.get_default()

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:83
    this.gExtensions._dash2panelSettingsCache = ext.getSettings( "org.gnome.shell.extensions.dash-to-panel" )
  • extension.js:108
    this.settings = this.getSettings( "org.gnome.shell.extensions.worksets" )

All Versions

Previous Reviews on this Version

k-extd posted a review
I reviewed the shexli warnings before upload, they're all irrelevant or false positives. You should add/document the ability to put per line rule disable directives with required commentary and classify them differently for your review, perhaps saving line numbers to ignore them in the future. Also may be useful to use the web review UI prior to upload submission, for new users.
fmuellner active