GNOME Shell Extensions

Review of "Simple Timer" version 23

Details Page Preview

Simple Timer

by Majortom

Simple Timer is a Gnome Shell Extension that adds a Timer to the Panel.

Extension Homepage
https://github.com/MajortomVR/simple-timer-extension
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:49 
          this.panelButton.menu.connect('open-state-changed', (menu, isOpen) => {
         if (isOpen) {
            this.menuOpeningDelayID = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 100, () => {
               this.menuTimerInputEntry.grab_key_focus();
               this.menuOpeningDelayID = null;

All Versions

Version Status
23 Active
22 Active
21 Active
20 Inactive
19 Active
18 Rejected
17 Rejected
16 Rejected
15 Active
14 Active
13 Rejected
12 Active
11 Active
10 Rejected
9 Active
8 Active
7 Active
6 Rejected
5 Rejected
4 Active
3 Rejected
2 Rejected
1 Active

Previous Reviews on this Version

GdH active
Just a note - you can use this.timerLabel?.destroy(); instead of if (this.timerLabel) this.timerLabel.destroy();