GNOME Shell Extensions

Review of "Blur my Shell" version 77

Details Page Preview

Blur my Shell

by aunetx

Adds a blur look to different parts of GNOME Shell, including the top panel, dash and overview. Note: if the extension shows an error after updating, restart your session to see whether it persists. This is due to a GNOME Shell bug that the extension cannot work around.

Extension Homepage
https://github.com/aunetx/blur-my-shell
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 2 warning 3

Shexli found 5 issues that may need reviewer attention.

EGO-I-003 error

Clutter, Meta, St and Shell must not be imported in prefs process files

GNOME Shell library `Clutter` must not be imported in preferences files.

Do not import GNOME Shell libraries in Preferences

  • render/shader/shader_effect.js:1 
    import Clutter from 'gi://Clutter';

EGO-P-004 error

GSettings schema XML filename must match schema id

GSettings schema filename must match `<schema-id>.gschema.xml`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.blur-my-shell.gschema.xml 
    id='org.gnome.shell.extensions.blur-my-shell.overview' path='/org/gnome/shell/extensions/blur-my-shell/overview/'
  • schemas/org.gnome.shell.extensions.blur-my-shell.gschema.xml 
    id='org.gnome.shell.extensions.blur-my-shell.appfolder' path='/org/gnome/shell/extensions/blur-my-shell/appfolder/'
  • schemas/org.gnome.shell.extensions.blur-my-shell.gschema.xml 
    id='org.gnome.shell.extensions.blur-my-shell.panel' path='/org/gnome/shell/extensions/blur-my-shell/panel/'
  • schemas/org.gnome.shell.extensions.blur-my-shell.gschema.xml 
    id='org.gnome.shell.extensions.blur-my-shell.dash-to-dock' path='/org/gnome/shell/extensions/blur-my-shell/dash-to-dock/'
  • schemas/org.gnome.shell.extensions.blur-my-shell.gschema.xml 
    id='org.gnome.shell.extensions.blur-my-shell.applications' path='/org/gnome/shell/extensions/blur-my-shell/applications/'
  • schemas/org.gnome.shell.extensions.blur-my-shell.gschema.xml 
    id='org.gnome.shell.extensions.blur-my-shell.screenshot' path='/org/gnome/shell/extensions/blur-my-shell/screenshot/'
  • schemas/org.gnome.shell.extensions.blur-my-shell.gschema.xml 
    id='org.gnome.shell.extensions.blur-my-shell.lockscreen' path='/org/gnome/shell/extensions/blur-my-shell/lockscreen/'
  • schemas/org.gnome.shell.extensions.blur-my-shell.gschema.xml 
    id='org.gnome.shell.extensions.blur-my-shell.window-list' path='/org/gnome/shell/extensions/blur-my-shell/window-list/'
  • schemas/org.gnome.shell.extensions.blur-my-shell.gschema.xml 
    id='org.gnome.shell.extensions.blur-my-shell.coverflow-alt-tab' path='/org/gnome/shell/extensions/blur-my-shell/coverflow-alt-tab/'
  • schemas/org.gnome.shell.extensions.blur-my-shell.gschema.xml 
    id='org.gnome.shell.extensions.blur-my-shell.popup' path='/org/gnome/shell/extensions/blur-my-shell/popup/'
  • schemas/org.gnome.shell.extensions.blur-my-shell.gschema.xml 
    id='org.gnome.shell.extensions.blur-my-shell.hidetopbar' path='/org/gnome/shell/extensions/blur-my-shell/hidetopbar/'
  • schemas/org.gnome.shell.extensions.blur-my-shell.gschema.xml 
    id='org.gnome.shell.extensions.blur-my-shell.dash-to-panel' path='/org/gnome/shell/extensions/blur-my-shell/dash-to-panel/'

EGO-L-001 warning

extension must not create GObject instances or modify shell before enable()

Resource creation or signal/source setup was found outside `enable()`.

Only use initialization for static resources

  • render/paint_nodes.js:10 
    new Clutter.ActorBox()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • components/dock/dash_to_dock.js:70 
                    watch.connections.connect(actor, WATCHED_TARGET_SIGNALS[watch.role],
                    () => this.retry())
  • components/dock/dash_to_dock.js:40 
            this.connections.connect(container, ['notify::allocation', 'child-added'],
            () => this.retry())
  • components/dock/dash_to_dock.js:42 
    this.connections.connect(container, 'notify::mapped', () => this.queue_map_retry())
  • components/dock/dash_to_dock.js:43 
    this.connections.connect(container, 'destroy', () => this.destroy())
  • components/dock/dash_to_dock.js:47 
                this.connections.connect(slider, ['notify::child', 'child-added', 'child-removed'],
                () => this.retry())
  • extension.js:52 
    this._connection.connect(Main.uiGroup, 'destroy', () => this.disable())
  • extension.js:77 
            this._connection.connect(
            this._power_profile_monitor,
            'notify::power-saver-enabled',
            () => this._update_power_saver()
        )
  • extension.js:90 
            this._connection.connect(Main.sessionMode, 'updated',
            () => this._on_session_mode_changed(Main.sessionMode)
        )

EGO-M-008 warning

extensions using unlock-dialog must document it in disable() comments

Extensions using `unlock-dialog` should document the reason in `disable()` comments.

Session Modes

  • extension.js:108 
        disable() {
        this._log("disabling extension...");

        if (this._user_session_mode_enabled)
            this._disable_user_session();

        // these stay active outside of the user session
        this._popup.disable();
        this._lockscreen_blur.disable();
        this._applica

All Versions

Version Status
77 Unreviewed
76 Active
75 Active
74 Active
73 Rejected
72 Active
71 Active
70 Active
69 Active
68 Active
67 Active
66 Active
65 Active
64 Active
63 Active
62 Active
61 Active
60 Active
59 Active
58 Active
57 Rejected
56 Rejected
55 Active
54 Active
53 Active
52 Active
51 Active
50 Active
49 Rejected
48 Rejected
47 Active
46 Active
45 Active
44 Active
43 Active
42 Active
41 Active
40 Rejected
39 Active
38 Active
37 Active
36 Active
35 Active
34 Active
33 Active
32 Active
31 Active
30 Rejected
29 Active
28 Active
27 Active
26 Active
25 Active
24 Active
23 Active
22 Active
21 Active
20 Active
19 Active
18 Active
17 Rejected
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active