GNOME Shell Extensions

Review of "Iranian Persian Calendar" version 48

Details Page Preview

Iranian Persian Calendar

by scr.ir

تقویم هجری شمسی،قمری و میلادی در میز‌کار گنوم لینوکس قابلیت نمایش اوقات شرعی و پخش اذان درج تعطیلی‌ها و مناسبت‌های رسمی تقویم زبان کاملاً فارسی تاریخ قمری هلالی ایران سازگار با اکثر نسخه‌های گنوم در حال توسعه... Shows Persian + Islamic + Gregorian date in the panel of gnome. It shows: 1- Persian calendar 2- It can show, today is holiday or not! 3- Show notification onDayChanged! 4- Date converter between Persian(Hijri Shamsi, Jalali, Iranian), Gregorian and Lunar Hijri(Islamic, Ghamari) 5- Show calendar Events. 6- Show PrayTimes and play sound (Azan). Please "rate" here and "star" project in GitHub. Please open an issue in GitHub if you found something or have an idea! گزارش مشکلات: https://github.com/SCR-IR/gnome-shamsi-calendar/issues

Extension Homepage
https://github.com/scr-ir/gnome-shamsi-calendar
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled 
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:284 
          this.menu.connect('open-state-changed', (menu, isOpen) => {
        if (isOpen) {
          that._calendar._selectedDateObj.setNow();
          that._calendar._update();
        }
      })
  • extension.js:51 
          this.interface_schema_gnome_theme_change_signal = this.interface_schema.connect('changed', () => {
        onChangeTheme();
        _arg.restartExtension();
      })

All Versions

Previous Reviews on this Version

JustPerfection active
JustPerfection posted a review
Please remove `schemas/gschemas.compiled` for the next version.