Details Page Preview

Add or override the brightness slider to change the brightness via an alpha layer (and optionally stop using or cooperate with the exising backlight, if present). Either internal, external or all monitors can be dimmed. See the GitHub page for details. Note that this extension will keep running on the lock screen, as you'd also want the brightness setting to apply to the lock screen as well. Please report on GitHub if this gives you any trouble.

Extension Homepage
https://github.com/F-i-f/soft-brightness

No comments.

Diff Against Previous Version

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
12 Active
11 Rejected
10 Rejected
9 Inactive
8 Active
7 Active
6 Inactive
5 Active
4 Inactive
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

andyholmes waiting for author
I have approved v3 of your extension, however this version does not setup/cleanup in `enable()` and `disable()`. Unless you'd like to resubmit with those changes, I'll leave this for another reviewer to reject or accept.
philippetroin posted a review
Version 3 doesn't clean-up in disable() either, this is an intended behavior. I understand the rationale behind the rule of cleaning up on disable(). If you look closely, the extension's behavior is to skip disabling when disable() is called when the lock screen is activating. This is intentional as the user may not want the lock screen to be on full-brightness. In all other cases besides the lock screen activating, disable() effectively disables the extensions, disconnects all signals etc. There's unfortunately or not no concept of "trusted extension" that would be allowed to keep running on the lock screen. This extension (all versions I've uploaded from v1 to v4) only partially disables the extension when the lock screen is activating: disable() is called, but _disable() isn't. Would you consider a compromise where the extension would be disabled normally on the lock screen (disable() would be always effective and would call _disable()) , but which could be toggled by a preference that would enable the current behavior (extension keeps running on the lock screen, disable() doesn't call _disable() when called upon entering the lock screen).
andyholmes active
Disregard, my mistake.
andyholmes posted a review
Sorry, to clarify, I missed that enable()/disable() had been moved to the extension object. Since this replaces an option already available on the lock-screen I understand your approach. Perhaps a note to users that this is the case would be appropriate.
philippetroin posted a review
Thanks for your constructive comment I've added this paragraph to the description: Note that this extension will keep running on the lock screen, as you'd also want the brightness setting to apply to the lock screen as well. Please comment if this gives you any trouble.