Review "AppIndicator and KStatusNotifierItem Support" version 41

Review of "AppIndicator and KStatusNotifierItem Support" version 41

Details Page Preview

AppIndicator and KStatusNotifierItem Support

by 3v1n0

Adds AppIndicator, KStatusNotifierItem and legacy Tray icons support to the Shell

Extension Homepage: https://github.com/ubuntu/gnome-shell-extension-appindicator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
64	Unreviewed
63	Active
62	Rejected
61	Active
60	Active
59	Active
58	Active
57	Active
56	Active
55	Rejected
54	Rejected
53	Active
52	Active
51	Active
50	Active
49	Active
48	Active
47	Active
46	Active
45	Active
44	Active
43	Active
42	Active
41	Active
40	Active
39	Rejected
38	Rejected
37	Active
36	Active
35	Active
34	Active
33	Active
32	Active
31	Active
30	Active
29	Active
28	Active
27	Active
26	Active
25	Rejected
24	Active
23	Active
22	Active
21	Active
20	Active
19	Active
18	Active
17	Active
16	Rejected
15	Active
14	Active
13	Active
12	Rejected
11	Active
10	Active
9	Active
8	Active
7	Active
6	Active
5	Active
4	Rejected
3	Rejected
2	Rejected
1	Active

Previous Reviews on this Version

JustPerfection waiting for author September 30, 2021

prefs.js: `imports.misc.extensionUtils;` in try catch block never throws any error since we have that in 3.34 and higher. and `Me` will be a correct value all the time. so those lines depending on them will never be executed. The question is: Why are you doing it like that?

3v1n0 posted a review September 30, 2021

@JustPerfection: I want to be able to quickly run the prefs as standalone application with `gjs prefs.js` in both gtk3 and gtk4 for faster development, thus that. As you said that won't never happen when running inside the shell, so the code is relevant only here.

JustPerfection active September 30, 2021