Review of "AppIndicator and KStatusNotifierItem Support" version 8

Details Page Preview

Adds AppIndicator, KStatusNotifierItem and legacy Tray icons support to the Shell

Extension Homepage
https://github.com/ubuntu/gnome-shell-extension-appindicator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

gcampax active
clutter_image_set_data() is not supposed to work, it's lacking a length argument - maybe previously it worked as a null terminated string, but that's obviously wrong for an image. set_bytes() OTOH is the right thing, as gjs implicitly converts byte arrays to and from GBytes
rgcjonas posted a review
It's interesting because set_data blows up in Ubuntu 13.04 with gnome3 ppa (gjs 1.36; instant segmentation fault). set_bytes however throws a TypeError in Ubuntu 12.10 (gjs 1.34), while set_data seems to work fine. Since clutter_image_set_data is incorrect, how should I handle that in GJS 1.34?
gcampax posted a review
You can't, you need gjs 1.36 to handle GBytes transparently. Use the GdkPixbuf as a GIcon instead, and use a StIcon derived from it.