GNOME Shell Extensions

Review of "AppIndicator and KStatusNotifierItem Support" version 55

Details Page Preview

AppIndicator and KStatusNotifierItem Support

by 3v1n0

Adds AppIndicator, KStatusNotifierItem and legacy Tray icons support to the Shell

Extension Homepage
https://github.com/ubuntu/gnome-shell-extension-appindicator
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
58 Active
57 Active
56 Active
55 Rejected
54 Rejected
53 Active
52 Active
51 Active
50 Active
49 Active
48 Active
47 Active
46 Active
45 Active
44 Active
43 Active
42 Active
41 Active
40 Active
39 Rejected
38 Rejected
37 Active
36 Active
35 Active
34 Active
33 Active
32 Active
31 Active
30 Active
29 Active
28 Active
27 Active
26 Active
25 Rejected
24 Active
23 Active
22 Active
21 Active
20 Active
19 Active
18 Active
17 Active
16 Rejected
15 Active
14 Active
13 Active
12 Rejected
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Active

Previous Reviews on this Version

JustPerfection rejected
Please remove line 45 (settingsManager.js). No need to use `run_dispose()` there. Nulling that out would be enough. and what's the reason for using `run_dispose()` in line 279 (statusNotifierWatcher.js)? as noted in the docs: > This function should only be called from object system implementations. https://gjs-docs.gnome.org/gobject20~2.0/gobject.object#method-run_dispose
3v1n0 posted a review
> and what's the reason for using `run_dispose()` in line 279 (statusNotifierWatcher.js)? The point is mostly to ensure that we do all the required dispose action even though gjs may keep a reference on it... It's basically like calling `destroy()` on a widget.