Review of "Weather" version 11

Details Page Preview

Animation Weather. Mouse 1: show weather Mouse 2: refresh weather Mouse 3: dismiss ScrollUp: increase day ScrollDown: decrease day Added i18n date, weather, temperature.

Extension Homepage
https://github.com/eexpress/gs-weather

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
16 Rejected
15 Active
14 Rejected
13 Active
12 Rejected
11 Rejected
10 Inactive
9 Inactive
8 Inactive
7 Inactive
6 Inactive
5 Inactive
4 Rejected
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

eexpss posted a review
Change to libsoup-3. I really don't know if this can compatible with soup 2.4. I test it on fedora. Add i18n format date display.
JustPerfection waiting for author
Line 1 (extension.js) should be removed because the version is set here: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/9d47062c3282b0f103d25a5d3412f28d7766c252/js/ui/environment.js#L36-44 Why don't you can check the current version like this: ```js if (imports.gi.versions.Soup === '2.4') { // 2.4 } else { // 3.0 } ```
eexpss posted a review
I just don't know if the js/ui/environment.js has been launched every time when login. If true, the _injectSoup3Compat(Soup); line at https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/9d47062c3282b0f103d25a5d3412f28d7766c252/js/ui/environment.js#L36-44 had do the compatible thing and I only need write with soup3, right? I dislike write those branch to judge version. :D And someone using manjaro(based on Arch) report an issue about the Soup version, I also don't know which soup version be used in his distro. Maybe '2.6' not '2.4', how can I do with this situation.
JustPerfection waiting for author
When you set the version in extension.js, it won't do anything. Because it has been set before in the GNOME Shell environment. and yes, the `js/ui/environment.js` sets the GNOME Shell environments and it will be loaded on each start: https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/9d47062c3282b0f103d25a5d3412f28d7766c252/js/ui/init.js#L5
eexpss posted a review
Thanks, It so clear now, only `js/ui/environment.js` loaded before main.js. I upload other version, please reject this version. :D
JustPerfection rejected