Review of "Weather" version 12

Details Page Preview

Animation Weather. Mouse 1: show weather Mouse 2: refresh weather Mouse 3: dismiss ScrollUp: increase day ScrollDown: decrease day Added i18n date, weather, temperature.

Extension Homepage
https://github.com/eexpress/gs-weather

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
16 Rejected
15 Active
14 Rejected
13 Active
12 Rejected
11 Rejected
10 Inactive
9 Inactive
8 Inactive
7 Inactive
6 Inactive
5 Inactive
4 Rejected
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
You shouldn't remove the version line in prefs.js because that may give you error when 2.4 and 3.0 both installed. Only remove that line in extension.js.
eexpss posted a review
I really had remove this line in prefs.js and extension.js.
JustPerfection posted a review
I know. I mean don't remove it on "prefs.js".
eexpss posted a review
Oh, I see.
eexpss posted a review
I search all github code, only 6 prefs.js contain `imports.gi.versions.Soup = "2.4";`, no one import "3.0". I think maybe all them want compatible with ubuntu(using 2.4). So I also need import 2.4? right?
JustPerfection posted a review
If your code is compatible with both, just use "3.0".