Review of "Improved Workspace Indicator" version 17

Details Page Preview

Slightly improved workspace indicator that shows both current and in use workspaces similar to i3/sway

Extension Homepage
https://github.com/MichaelAquilina/improved-workspace-indicator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
21 Rejected
20 Active
19 Inactive
18 Inactive
17 Rejected
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Rejected
6 Rejected
5 Rejected
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
1. Don't use subprocess for opening url (line 211-217 prefs.js). Use One of the spawn functions in `misc.util`. https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/util.js 2. Also do this in disable: ```js this.settings = null; ```
MichaelAquilina posted a review
I might be missing something or doing something incorrectly, But when I try importing the `util` module like so: ```js const Util = imports.misc.util; ``` I get the following error: ``` ImportError: No JS module 'util' found in search path ``` I can import other modules found in misc like extensionUtils just fine. Do you have some documentation on this module you could point me at perhaps?
JustPerfection posted a review
Are you trying to import that in prefs.js?
MichaelAquilina posted a review
Yeah, as it's where the subprocess call I am trying to call is found
JustPerfection posted a review
You can use `GLib.spawn_command_line_sync` or `GLib.spawn_command_line_async` https://gjs-docs.gnome.org/glib20~2.0/glib.spawn_command_line_sync