Review of "Advanced Calculator" version 1

Details Page Preview

Quickly perform calculations in the shell overview. Supports 3.6! Radians now supported in trig functions by prefixing with 'r', ex: rsin('pi'/2) == 1

Extension Homepage
https://github.com/war1025/GCalcSearch

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
12 Active
11 Active
10 Active
9 Active
8 Active
7 Rejected
6 Active
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Active

Previous Reviews on this Version

gcampax posted a review
Technically fine, but wouldn't this be better as an improvement to the existing Calculator? (and isn't there any better way than calling out to gcalctool everytime I press a key?)
war1025 posted a review
Depends. As you say, this requires calling out to gcalctool, maybe some people don't care for that and would rather just have the javascript version. That said, I guess I could offer it to the existing Calculator tool. The main advantage of using gcalctool instead of javascript is you get access to trig functions, exponentiation, logarithms, etc. Maybe some people won't need to use the calculator for that. I believe I also read somewhere that the precision of javascript math isn't very good, probably not a big deal for some people though. As to the calling gcalctool, I have a primitive regex in place that requires there to at least be digits present. If it is a big deal, that could be modified to something more complex. All that is required is changing the _validExpression method. However, I'm not really sure what you would consider sufficient conditions to call the program. If you have a better idea, I'd be happy to implement it.
Jasper St. Pierre posted a review
This is fine with me.