Review of "Clipboard Indicator" version 5

Details Page Preview

The most popular clipboard manager for GNOME, with over 1M downloads

Extension Homepage
https://github.com/Tudmotu/gnome-shell-extension-clipboard-indicator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

fmuellner active
- the new prettyPrint() function calls the (no longer existent) dbPrintObj() - some nits: - forgot to delete convenience.js? - stat() (as called by g_file_info_query) may block as well, so if you want to avoid this, you'd have to use g_file_info_query_async() (yeah, nested async gets quite nasty fairly quickly :-/ ) - if your timeout handler returns false, the source is removed automatically; trying to remove it again in disable() will then result in a warning (harmless, but easily fixable by correctly resetting _clipboardTimeoutId) (none of this should block the extension though, so approving)
Tudmotu posted a review
What do you mean by 'resetting _clipboardTimeoutId'? Do you think maybe I can set some global variable from inside the 'disable()' function, and the timeout handler will return false once that variable has been set?
fmuellner posted a review
No, I meant exactly what you did in the new extension version.