Review "Clipboard Indicator" version 3

Review of "Clipboard Indicator" version 3

Details Page Preview

Clipboard Indicator

by Tudmotu

The most popular clipboard manager for GNOME, with over 2M downloads

Extension Homepage: https://github.com/Tudmotu/gnome-shell-extension-clipboard-indicator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Version	Status
70	Unreviewed
69	Active
68	Active
67	Rejected
66	Active
65	Active
64	Active
63	Active
62	Active
61	Active
60	Active
59	Active
58	Inactive
57	Active
56	Active
55	Active
54	Active
53	Active
52	Active
51	Active
50	Active
49	Rejected
48	Rejected
47	Active
46	Rejected
45	Active
44	Active
43	Active
42	Active
41	Rejected
40	Rejected
39	Inactive
38	Active
37	Active
36	Active
35	Inactive
34	Active
33	Active
32	Active
31	Inactive
30	Active
29	Active
28	Active
27	Active
26	Active
25	Active
24	Active
23	Active
22	Active
21	Active
20	Active
19	Active
18	Active
17	Active
16	Active
15	Active
14	Active
13	Active
12	Rejected
11	Active
10	Active
9	Active
8	Active
7	Active
6	Active
5	Active
4	Rejected
3	Rejected
2	Active
1	Rejected

Previous Reviews on this Version

fmuellner rejected July 8, 2014

- still doing the manual timeout recursion - calling the GSettings::changed handler id "_settingsTimeoutId" does not make it a timeout; you should do something like: this._settings.disconnect(this._changedId); in destroy() - nits: - "success" as return value for write_bytes_finish() is a bit odd, it's a size (also unused, so maybe just ignore?) - "let [success, contents] = obj.load_contents_finish(res);" is more readable The _settingsTimeoutId error needs fixing, so rejecting.