Review of "Clipboard Indicator" version 48

Details Page Preview

The most popular clipboard manager for GNOME, with over 2M downloads

Extension Homepage
https://github.com/Tudmotu/gnome-shell-extension-clipboard-indicator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli has not produced a result yet.

All Versions

Previous Reviews on this Version

Tudmotu auto- rejected
Auto-rejected because of new version 49 was uploaded
JustPerfection rejected
1. Please remove line 10 prefs.js. 2. Where is `constants.js` (line 8 prefs.js, line 15 extension.js)? 3. Please remove `utils.js` since you are not using it: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files 4. You need to null out `_openDialog` in disable (line 10 confirmDialog.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects 5. Move to enable and null out on disable (line 17 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-init-for-initialization 6. Remove timeout on destroy (line 141, 182 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#remove-main-loop-sources 7. Where do you set interval for `this._historyLabelTimeoutId` line 891 (extension.js)?
Tudmotu posted a review
1. Done 2. Added 3. Done 4. Refactored into class 5. Moved to be _init argument 6. Done 7. Lmao no idea, removed Uploaded new version