Review of "Clipboard Indicator" version 71

Details Page Preview

The most popular clipboard manager for GNOME, with over 2M downloads

Extension Homepage
https://github.com/Tudmotu/gnome-shell-extension-clipboard-indicator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4 manual_review 1

Shexli found 5 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:69
    St.Clipboard.get_default()

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 7 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:1047
    console.error('Clipboard Indicator: Failed to refresh indicator')
  • extension.js:1048
    console.error(e)
  • extension.js:1355
    console.error(e)
  • extension.js:1456
    console.error('Clipboard Indicator: Failed to update registry')
  • extension.js:1457
    console.error(e)
  • extension.js:1739
    console.error('Clipboard Indicator: failed to load image preview')
  • extension.js:1740
    console.error(e)

EGO-X-003 warning

extensions should not call run_dispose in extension code

Extension code should not call `run_dispose()`.

GObject.Object.run_dispose

  • keyboard.js:19
    this.#device.run_dispose()

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:1248
                this._notifSource.connect('destroy', () => {
                    this._notifSource = null;
                })
  • extension.js:373
    this.clearMenuItem.connect('activate', this._removeAll.bind(this))
  • extension.js:715
    menuItem.imagePreviewBtn.connect('clicked', () => this.#showImagePreview(entry))
  • extension.js:733
    menuItem.editBtn.connect('clicked', () => this.#showEditDialog(menuItem))
  • extension.js:772
            menuItem.pasteBtn.connect('clicked',
                () => this.#pasteItem(menuItem)
            )
  • extension.js:792
    menuItem.tagBtn.connect('clicked', () => this.#showTagDialog(menuItem))
  • extension.js:631
            menuItem.actor.connect('key-press-event', (actor, event) => {
                switch (event.get_key_symbol()) {
                    case Clutter.KEY_Delete:
                        if (menuItem.entry.isFavorite()) {
                            if (CONFIRM_ON_PINNED_DELETE) {
                                this
  • extension.js:115
            this.menu.connect('open-state-changed', (menu, isOpen) => {
                if (!isOpen)
                    this.menu.sourceActor = this;
            })
  • extension.js:255
            this.menu.connect('open-state-changed', (self, open) => {
                this._setFocusOnOpenTimeout = setTimeout(() => {
                    if (!open) return;
    
                    if (this._focusItemOnOpen) {
                        const item = this._focusItemOnOpen;
                        this._focusItemO
  • extension.js:365
            this.resetTimerButton.connect('clicked', () => {
                this._scheduleNextHistoryClear();
            })
  • extension.js:385
    this.settingsMenuItem.connect('activate', this._openSettings.bind(this))

All Versions

Previous Reviews on this Version

fmuellner active