Review "Privacy Quick Settings" version 19

Review of "Privacy Quick Settings" version 19

Details Page Preview

Privacy Quick Settings

Add privacy settings toggles to the GNOME system menu NOTE: This only provides quick access to settings, it doesn't directly access hardware

Extension Homepage: https://github.com/stuarthayhurst/privacy-menu-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version	Status
25	Active
24	Active
23	Active
22	Active
21	Active
20	Active
19	Rejected
18	Active
17	Active
16	Active
15	Rejected
14	Active
13	Active
12	Active
11	Active
10	Active
9	Active
8	Active
7	Active
6	Active
5	Active
4	Active
3	Active
2	Active
1	Active

Previous Reviews on this Version

JustPerfection rejected August 21, 2023

LGTM but don't use generic name for the module you are exporting (line 318 extension.js) For example, use `PrivacyQuickSettings` as class name. or the class name in line 123 prefs.js can be `PrivacyQuickSettingsPrefs`.

Stuart Hayhurst posted a review August 21, 2023

Whoops sorry, I assumed that was fine after Alphabetical App Grid got approved, I'll patch both of them