GNOME Shell Extensions

Review of "Privacy Quick Settings" version 29

Details Page Preview

Privacy Quick Settings

by stuarthayhurst

Add privacy settings toggles to the GNOME system menu NOTE: This only provides quick access to settings, it doesn't directly access hardware

Extension Homepage
https://github.com/stuarthayhurst/privacy-menu-extension
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 2 warning 2

Shexli found 4 issues that may need reviewer attention.

EGO-P-004 error

GSettings schema XML filename must match schema id

GSettings schema filename must match `<schema-id>.gschema.xml`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.PrivacyMenu.gschema.xml 
    id='org.gnome.shell.extensions.privacy-menu' path='/org/gnome/shell/extensions/privacy-menu/'

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:304 
            new PrivacyQuickToggle(
          quickSettingInfo[0], quickSettingInfo[1],
          quickSettingInfo[2], quickSettingInfo[3],
          quickSettingInfo[4]
        )
  • extension.js:331 
    this._quickSettingsGroup = new PrivacyQuickGroup(extension, useQuickSubtitle, clickToToggle)
  • extension.js:346 
    this._indicator = new PrivacyIndicator()

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:331 
    this._quickSettingsGroup = new PrivacyQuickGroup(extension, useQuickSubtitle, clickToToggle)
  • extension.js:346 
    this._indicator = new PrivacyIndicator()
  • extension.js:390 
    this._extensionSettings = this._extension.getSettings()

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json 
    shell-version=['45', '46', '47', '48', '49', '50', '51']

All Versions

Version Status
30 Active
29 Rejected
28 Active
27 Active
26 Active
25 Active
24 Active
23 Active
22 Active
21 Active
20 Active
19 Rejected
18 Active
17 Active
16 Active
15 Rejected
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
Please rename the xml file to `schemas/org.gnome.shell.extensions.privacy-menu.gschema.xml`