Review of "Quake Terminal" version 1.1.0 (35)

Details Page Preview

Quickly launch a terminal in Quake mode using a keyboard shortcut

Extension Homepage
https://github.com/diegodario88/quake-terminal

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 17 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • quake-mode.js:37
        console.log(
          `*** QuakeTerminal@constructor - IsWayland = ${SHELL_VERSION >= 50 || Meta.is_wayland_compositor()} ***`
        )
  • quake-mode.js:40
        console.log(
          `*** QuakeTerminal@constructor - Terminal App = ${terminal.get_name()} ***`
        )
  • quake-mode.js:112
          console.log(
            `*** QuakeTerminal@terminalWindow - There's no terminal application ***`
          )
  • quake-mode.js:115
          console.log(
            `*** QuakeTerminal@terminalWindow - Current state ${this._internalState}  ***`
          )
  • quake-mode.js:122
          console.log(
            `*** QuakeTerminal@terminalWindow - There's no WindowActor, finding one ... ***`
          )
  • quake-mode.js:144
                console.log(
                  `*** QuakeTerminal@Unmanaged Called unmanaged after suspend or lockscreen ***`
                )
  • quake-mode.js:158
    console.log(`*** QuakeTerminal@actor - There's no terminalWindow ***`)
  • quake-mode.js:170
    console.log(`*** QuakeTerminal@actor - There's no actor ***`)
  • quake-mode.js:215
    console.log(`*** QuakeTerminal@destroy - Starting destroy action ***`)
  • quake-mode.js:272
    console.log(`*** QuakeTerminal@toggle - Catch error ${error} ***`)

All Versions

Version Status
1.1.0 (35) Unreviewed
1.0.5 (34) Active
1.0.4 (33) Active
1.0.3 (32) Active
1.0.2 (31) Active
1.0.1 (30) Active
1.0.1 (29) Active
1.6.9 (28) Active
1.6.9 (27) Active
1.6.8 (26) Rejected
1.6.6 (25) Active
1.6.6 (24) Active
1.6.5 (23) Active
1.6.4 (22) Active
1.6.3 (21) Rejected
1.6.3 (20) Active
1.6.2 (19) Active
1.6.1 (18) Active
1.6.1 (17) Active
16 Inactive
15 Inactive
14 Inactive
13 Inactive
12 Rejected
11 Inactive
10 Inactive
9 Rejected
8 Rejected
7 Rejected
6 Rejected
5 Inactive
4 Inactive
3 Rejected
2 Inactive
1 Rejected