Review of "IBus Tweaker" version 50

Details Page Preview

Tweak IBus font, input mode, clipboard history, etc. For support, please report issues in time via the Homepage link below rather than the review section below it

Extension Homepage
https://github.com/tuberry/ibus-tweaker

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO029 warning

extensions should not call run_dispose in extension code

Extension code should not call `run_dispose()`.

GObject.Object.run_dispose

  • fubar.js:120
    x.run_dispose()

EGO036 warning

extensions should not use lookupByURL or lookupByUUID for current extension access

Use `this`, `this.getSettings()` or `this.path` instead of `lookupByURL()` or `lookupByUUID()` for the current extension.

`extensionUtils`

  • fubar.js:25
    Extension.lookupByURL(import.meta.url)

All Versions

Previous Reviews on this Version

dlandau active
Check those shexli messages for next time
grroot posted a review
Thanks for reviewing. :) > EGO029 `run_dispose` This follows the GNOME Shell practice [0] thus is considered ‘absolutely necessary’ and has been commented in accordance with the guidelines [1]. [0] https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/a540670a9f468298fb7ccce6f2544cd4180a4db1/js/ui/keyboard.js#L1996-L1998 [1] https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-should-not-force-dispose-a-gobject > EGO036 `lookupByURL` I haven’t seen this mentioned in the review guidelines [2]. Since the lifecycle of the extension instance [3] is the same as that of the GNOME Shell, it should be treated as global, so banning it [4] alongside temporary `gsetting` instances for the same reason is baffling. Although passing global value around everywhere is messy and confusing, if it were also considered `absolutely necessary`, I will fix it next time. [2] https://gjs.guide/extensions/review-guidelines/review-guidelines.html [3] https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/a540670a9f468298fb7ccce6f2544cd4180a4db1/js/extensions/sharedInternals.js#L18 [4] https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/a540670a9f468298fb7ccce6f2544cd4180a4db1/js/ui/extensionSystem.js#L209