Review of "Brightness control using ddcutil" version 59

Details Page Preview

Brightness control for all the monitors detected by ddcutil This tool uses ddcutil as backend for communication with your display. Read setup instructions from: https://github.com/daitj/gnome-display-brightness-ddcutil/blob/master/README.md

Extension Homepage
https://github.com/daitj/gnome-display-brightness-ddcutil

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:753
            monitorSignals = {
                change: Main.layoutManager.connect('monitors-changed', this.onMonitorChange.bind(this)),
            }

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:376
    display.proxy.connect('g-properties-changed', () => sync())

All Versions