Review of "Bluetooth Quick Connect" version 55

Details Page Preview

This extension allows paired Bluetooth devices to be connected and disconnected via the GNOME system menu, Shows battery status and more.

Extension Homepage
https://github.com/Extensions-Valhalla/gnome-bluetooth-quick-connect

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:42
    this._menu = new PopupMenu.PopupMenuSection()

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • settings.js:21
    this.settings = extension.getSettings()

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:62
    		GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
    			if (!Main.panel.statusArea.quickSettings._bluetooth) return GLib.SOURCE_CONTINUE;
    			const bluetoothToggle = Main.panel.statusArea.quickSettings._bluetooth.quickSettingsItems[0];
    			bluetoothToggle._updateDeviceVisibility = () => {
    				bluetoothToggl

All Versions

Previous Reviews on this Version

fmuellner active