Review of "DownFall" version 44

Details Page Preview

Moves text of your choice across the screen. Can simulate leaves, snow, fireworks, ufos, and more!

Extension Homepage
https://github.com/torculus/DownFall

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:487
    this.featToggle = new FeatureToggle(this, this.fim)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:484
    this._settings.connect('changed', this.fim.settingsChanged.bind(this.fim))

All Versions

Previous Reviews on this Version

bsosenba auto- rejected
Auto-rejected because of new version 45 was uploaded