GNOME Shell Extensions

Review of "DownFall" version 43

Details Page Preview

DownFall

by bsosenba

Moves text of your choice across the screen. Can simulate leaves, snow, fireworks, ufos, and more!

Extension Homepage
https://github.com/torculus/DownFall
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:513 
    this.featToggle = new FeatureToggle(this, this.fim)

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:513 
    this.featToggle = new FeatureToggle(this, this.fim)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:292 
    this.settings.connect('changed', this.settingsChanged.bind(this))

All Versions

Previous Reviews on this Version

fmuellner active
FYI, simply replacing "ease()" with "easeAsync()" isn't really useful. It allows you to replace onComplete/onStopped callbacks with async code like await this.easeAsync(...); this.finish(); It still works to pass in onComplete/onStopped handlers instead, but then you can just as well use the regular "ease()".