Review of "Port Forwarding Extension" version 11

Details Page Preview

Extension to enable port forwarding via SSH

Extension Homepage
https://github.com/SJBERTRAND/portforwarding-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:225
            this._settings.connect('changed::show-connection1', ()=> {
                if ( this._settings.get_boolean('show-connection1') == true ){
            _sshForwarding._createSwitches(this._settings,this.menu,1,this._icon,this._cancellable,_section);
                };
            })
  • extension.js:234
            this._settings.connect('changed::show-connection2', ()=> {
                if ( this._settings.get_boolean('show-connection2') == true ){
            _sshForwarding._createSwitches(this._settings,this.menu,2,this._icon,this._cancellable,_section);
                };
            })
  • extension.js:244
            this._settings.connect('changed::show-connection3', ()=> {
                if ( this._settings.get_boolean('show-connection3') == true ){
            _sshForwarding._createSwitches(this._settings,this.menu,3,this._icon,this._cancellable,_section);
                };
            })
  • extension.js:254
            this._settings.connect('changed::show-connection4', ()=> {
                if ( this._settings.get_boolean('show-connection4') == true ){
            _sshForwarding._createSwitches(this._settings,this.menu,4,this._icon,this._cancellable,_section);
                };
            })
  • extension.js:263
            this._settings.connect('changed::show-connection5', ()=> {
                if ( this._settings.get_boolean('show-connection5') == true ){
                    _sshForwarding._createSwitches(this._settings,this.menu,5,this._icon,this._cancellable,_section);
                };
            })

All Versions

Version Status
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Rejected
2 Active
1 Active

Previous Reviews on this Version

fmuellner active