EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

• src/processor/processorMonitor.js:289

  GLib.file_get_contents('/sys/devices/system/cpu/present')

• src/processor/processorMonitor.js:347

  GLib.file_get_contents('/proc/cpuinfo')

• src/storage/storageMonitor.js:406

  GLib.file_get_contents(`/sys/block/${device}/queue/hw_sector_size`)

• src/utils/utils.js:322

  GLib.file_get_contents('/proc/stat')

• src/utils/utils.js:331

  GLib.file_get_contents('/proc/cpuinfo')

• src/utils/utils.js:340

  GLib.file_get_contents('/proc/meminfo')

• src/utils/utils.js:349

  GLib.file_get_contents('/proc/diskstats')

• src/utils/utils.js:358

  GLib.file_get_contents('/proc/net/dev')

• src/utils/utils.js:512

  GLib.file_get_contents('/sys/devices/system/cpu/present')

• src/utils/utils.js:519

  GLib.file_get_contents(path)

• src/utils/utils.js:1170

  GLib.file_get_contents('/proc/uptime')

• src/utils/utils.js:1528

  file.load_contents(null)

EGO-X-002 warning

extensions should not use synchronous subprocess APIs in shell code

Shell code should avoid synchronous subprocess APIs like `GLib.spawn_command_line_sync()` and `GLib.spawn_sync()`.

Complete Examples

• src/processor/processorMonitor.js:310

  GLib.spawn_command_line_sync(`${path}lscpu`)

• src/utils/utils.js:309

  GLib.spawn_command_line_sync(path + fullCommand)

• src/utils/utils.js:533

  GLib.spawn_command_line_sync('ps -V')

• src/utils/utils.js:825

  GLib.spawn_command_line_sync(`${path}sensors -j`)

• src/utils/utils.js:968

  GLib.spawn_command_line_sync(`${path}lspci -nnk`)

• src/utils/utils.js:1237

  GLib.spawn_command_line_sync(`${path}lsblk -J -o ID,NAME,LABEL,MOUNTPOINTS,PATH`)

• src/utils/utils.js:1619

  GLib.spawn_command_line_sync(`${path}ip -d -j addr`)

• src/utils/utils.js:1808

  GLib.spawn_command_line_sync(`${commandPath}lsblk -Jb -o ID,UUID,NAME,KNAME,PKNAME,LABEL,TYPE,SUBSYSTEMS,MOUNTPOINTS,VENDOR,MODEL,PATH,RM,RO,STATE,OWNER,SIZE,FSUSE%,FSTYPE`)

• src/utils/utils.js:2199

  GLib.spawn_command_line_sync('which nethogs')

• src/utils/utils.js:2210

  GLib.spawn_command_line_sync(`getcap ${nethogs}`)

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

• src/utils/cancellableTaskManager.js:27

              this.timeoutId = GLib.idle_add(GLib.PRIORITY_DEFAULT_IDLE, () => {
                  try {
                      this.boundTask()
                          .then(resolve)
                          .catch(reject)
                          .finally(() => {
                          this.rejectFn = und

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

• prefs.js:99

  this.welcome = new Welcome(this)

• prefs.js:100

  this.profiles = new Profiles(this)

• prefs.js:101

  this.visualization = new Visualization(this)

• prefs.js:102

  this.processors = new Processors(this)

• prefs.js:103

  this.gpu = new Gpu(this)

• prefs.js:104

  this.memory = new Memory(this)

• prefs.js:105

  this.storage = new Storage(this)

• prefs.js:106

  this.network = new Network(this)

• prefs.js:107

  this.sensors = new Sensors(this)

• prefs.js:108

  this.utility = new Utility(this, window)