Review of "Simple Taskbar" version 2

Details Page Preview

A configurable taskbar and Dock for GNOME Shell. - Pinned and running applications with live previews, grouping, overflow and drag-and-drop ordering. - Custom panel and Dock placement, appearance, auto-hide, window dodge, workspace scrolling and multi-monitor support. - Configurable panel items, locations, Trash, drives and common-folder shortcuts. - Grid Alt-Tab, an application volume mixer and Super+number application shortcuts. - Optional Eleven-style Start Menu with search, categories, pinned apps and system shortcuts. - Taskbar, Dock, Default GNOME Panel and Windows XP Theme modes. - Export and import profiles for panel, Dock and Start Menu settings. Some global search results may request that provider-supplied text be copied to the clipboard when activated.

Extension Homepage
https://github.com/Sultech/simple-taskbar

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • multiMonitorController.js:296
    this._menuManager = new PopupMenu.PopupMenuManager(this.actor)
  • multiMonitorController.js:274
            this._taskbarBin = new St.ScrollView({
                style_class: 'simple-taskbar-bin',
                hscrollbar_policy: St.PolicyType.EXTERNAL,
                vscrollbar_policy: St.PolicyType.NEVER,
                enable_mouse_scrolling: true,
                clip_to_allocation: true,
                visible

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:240
            this._showDesktopButton.connect('clicked', () =>
                this._windowController.toggleDesktop()
            )

All Versions

Previous Reviews on this Version

Sultech auto- rejected
Auto-rejected because of new version 3 was uploaded