Review of "Simple Taskbar" version 19

Details Page Preview

A configurable taskbar and Dock for GNOME Shell. - Pinned and running applications with live previews, grouping, overflow and drag-and-drop ordering. - Custom panel and Dock placement, appearance, auto-hide, window dodge, workspace scrolling and multi-monitor support. - Configurable panel items, locations, Trash, drives and common-folder shortcuts. - Grid Alt-Tab, an application volume mixer and Super+number application shortcuts. - Optional Eleven-style Start Menu with search, categories, pinned apps and system shortcuts. - Taskbar, Dock, Default GNOME Panel and Windows XP Theme modes. - Export and import profiles for panel, Dock and Start Menu settings. Some global search results may request that provider-supplied text be copied to the clipboard when activated.

Extension Homepage
https://github.com/Sultech/simple-taskbar

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3 manual_review 1

Shexli found 4 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • windowsStartMenu.js:1431
    St.Clipboard.get_default()

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • multiMonitorController.js:357
    this._menuManager = new PopupMenu.PopupMenuManager(this.actor)
  • volumeMixerController.js:287
                this._emptyItem = new PopupMenu.PopupMenuItem(
                    _('No applications are playing audio'),
                    {reactive: false}
                )
  • volumeMixerController.js:241
    this._streamSection = new PopupMenu.PopupMenuSection()

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • volumeMixerController.js:287
                this._emptyItem = new PopupMenu.PopupMenuItem(
                    _('No applications are playing audio'),
                    {reactive: false}
                )
  • volumeMixerController.js:241
    this._streamSection = new PopupMenu.PopupMenuSection()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • volumeMixerController.js:140
            this._sliderChangedId = this.slider.connect(
                'notify::value',
                () => this._sliderChanged()
            )

All Versions

Previous Reviews on this Version

Sultech auto- rejected
Auto-rejected because of new version 20 was uploaded