Review of "Simple Taskbar" version 6

Details Page Preview

Turns GNOME Shell's native panel into a configurable taskbar with pinned and running apps, live window previews, multi-monitor support, auto-hide, workspace isolation, and an optional Eleven-style Start Menu. Place the panel at the top or bottom, customize its size, spacing, transparency and theme, arrange Shell items, or switch to a clean native-style GNOME panel and retain all customization options offered by the extension. Activating some global search results may copy provider-supplied text to the clipboard.

Extension Homepage
https://github.com/Sultech/simple-taskbar

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • multiMonitorController.js:299
    this._menuManager = new PopupMenu.PopupMenuManager(this.actor)
  • multiMonitorController.js:277
            this._taskbarBin = new St.ScrollView({
                style_class: 'simple-taskbar-bin',
                hscrollbar_policy: St.PolicyType.NEVER,
                vscrollbar_policy: St.PolicyType.NEVER,
                enable_mouse_scrolling: true,
                clip_to_allocation: true,
                visible: !

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:245
            this._showDesktopButton.connect('clicked', () =>
                this._windowController.toggleDesktop()
            )

All Versions

Version Status
14 Active
13 Rejected
12 Rejected
11 Rejected
10 Rejected
9 Rejected
8 Rejected
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

Sultech auto- rejected
Auto-rejected because of new version 7 was uploaded