Review of "Simple Taskbar" version 43

Details Page Preview

A configurable taskbar and Dock for GNOME Shell. - Pinned and running applications with live previews, grouping, overflow and drag-and-drop ordering. - Custom panel and Dock placement, appearance, auto-hide, window dodge, workspace scrolling and multi-monitor support. - Configurable panel items, locations, Trash, drives and common-folder shortcuts. - Grid Alt-Tab, an application volume mixer and Super+number application shortcuts. - Optional Eleven-style Start Menu with search, categories, pinned apps and system shortcuts. - Taskbar, Dock, Default GNOME Panel and Windows XP Theme modes. - Export and import profiles for panel, Dock and Start Menu settings. Some global search results may request that provider-supplied text be copied to the clipboard when activated.

Extension Homepage
https://github.com/Sultech/simple-taskbar

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1 manual_review 1

Shexli found 2 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • windowsStartMenu.js:1768
    St.Clipboard.get_default()

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • multiMonitorController.js:375
    this._menuManager = new PopupMenu.PopupMenuManager(this.actor)

All Versions

Previous Reviews on this Version

JustPerfection active
Approved, since you are only monitoring the key change for calling a sync function in your extension (`blurMyShellUtils.js`). Please don't do more than that as debugging can create a headache for the other extension maintainers.