Review of "Simple Taskbar" version 7

Details Page Preview

Turns GNOME Shell's native panel into a configurable taskbar with pinned and running apps, live window previews, multi-monitor support, auto-hide, workspace isolation, and an optional Eleven-style Start Menu. Place the panel at the top or bottom, customize its size, spacing, transparency and theme, arrange Shell items, or switch to a clean native-style GNOME panel and retain all customization options offered by the extension. Activating some global search results may copy provider-supplied text to the clipboard.

Extension Homepage
https://github.com/Sultech/simple-taskbar

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3 manual_review 1

Shexli found 4 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 8 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • startMenuKeybindings.js:125
    console.error(`Failed to register Super+Tab: ${error}`)
  • startMenuKeybindings.js:156
    console.error(`Failed to configure the Super key: ${error}`)
  • startMenuKeybindings.js:208
    console.error(`Failed to replace the Super key handler: ${error}`)
  • startMenuKeybindings.js:259
    console.error(`Failed to restore the original Super key: ${error}`)
  • startMenuKeybindings.js:130
                console.warn(
                    `Simple Taskbar: Super+Tab ${mode} shortcut could not be registered`
                )
  • startMenuKeybindings.js:191
                console.warn(
                    'Simple Taskbar: GNOME overlay-key handler was not found'
                )
  • startMenuKeybindings.js:278
                console.warn(
                    `Failed to restore GNOME's Super key handler: ${error}`
                )
  • startMenuKeybindings.js:349
    console.warn('Simple Taskbar: custom Start menu shortcut could not be registered')

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • windowsStartMenu.js:1053
    St.Clipboard.get_default()

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • multiMonitorController.js:299
    this._menuManager = new PopupMenu.PopupMenuManager(this.actor)
  • multiMonitorController.js:277
            this._taskbarBin = new St.ScrollView({
                style_class: 'simple-taskbar-bin',
                hscrollbar_policy: St.PolicyType.NEVER,
                vscrollbar_policy: St.PolicyType.NEVER,
                enable_mouse_scrolling: true,
                clip_to_allocation: true,
                visible: !

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:254
            this._showDesktopButton.connect('clicked', () =>
                this._windowController.toggleDesktop()
            )

All Versions

Version Status
14 Active
13 Rejected
12 Rejected
11 Rejected
10 Rejected
9 Rejected
8 Rejected
7 Rejected
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

Sultech auto- rejected
Auto-rejected because of new version 8 was uploaded