Review of "Battery Session Timer" version 6

Details Page Preview

Battery session timer with record saving for GNOME Shell

Extension Homepage
https://github.com/Gluk41/battery-session-timer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 9 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:288
    console.warn(`Battery Session Timer: ошибка отключения сигнала UPower: ${error}`)
  • extension.js:395
    console.warn(`Battery Session Timer: logind недоступен, используется монотонный таймер: ${error}`)
  • extension.js:425
    console.warn(`Battery Session Timer: ошибка отключения сигнала logind: ${error}`)
  • extension.js:696
    console.warn(`Battery Session Timer: не удалось удалить файл сессии ${this._sessionFile}: ${error}`)
  • extension.js:234
    console.error(`Battery Session Timer: не удалось подключиться к UPower: ${error}`)
  • extension.js:258
    console.error(`Battery Session Timer: не удалось получить DisplayDevice: ${error}`)
  • extension.js:723
    console.error(`Battery Session Timer: не удалось сохранить ${description} ${path}: ${error}`)
  • extension.js:319
    console.log(`Battery Session Timer: питание было подключено во время сна — сбрасываем сессию`)
  • extension.js:336
    console.log(`Battery Session Timer: заряд увеличился на ${chargeDiff}% (было ${this._resumedChargePercent}%, стало ${currentCharge}%) — сбрасываем сессию`)

All Versions

Previous Reviews on this Version

Gluk41 auto- rejected
Auto-rejected because of new version 7 was uploaded