GNOME Shell Extensions

Review of "Battery Session Timer" version 19

Details Page Preview

Battery Session Timer

by Gluk41

Battery session timer with record saving for GNOME Shell

Extension Homepage
https://github.com/Gluk41/battery-session-timer
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:600 
    file.load_contents(null)
  • extension.js:623 
    file.load_contents(null)
  • extension.js:686 
    file.load_contents(null)

EGO-M-008 warning

extensions using unlock-dialog must document it in disable() comments

Extensions using `unlock-dialog` should document the reason in `disable()` comments.

Session Modes

  • extension.js:721 
        disable() {
        if (!this._enabled)
            return;

        this._tracker.tick(this._nowUs());
        const state = this._tracker.snapshot();
        this._saveRecordIfDirty();
        this._saveSessionState(state);
        this._enabled = false;

        if (this._timeoutId)

All Versions

Previous Reviews on this Version

Gluk41 auto- rejected
Auto-rejected because of new version 20 was uploaded