Review of "Battery Session Timer" version 9

Details Page Preview

Battery session timer with record saving for GNOME Shell

Extension Homepage
https://github.com/Gluk41/battery-session-timer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:467
            this._icon = new St.Icon({
                icon_name: 'battery-good-symbolic',
                style_class: 'system-status-icon',
            })
  • extension.js:471
            this._label = new St.Label({
                text: '',
                y_align: Clutter.ActorAlign.CENTER,
            })
  • extension.js:482
            this._recordItem = new PopupMenu.PopupMenuItem('', {
                reactive: false,
            })
  • extension.js:479
            this._sessionItem = new PopupMenu.PopupMenuItem('', {
                reactive: false,
            })

All Versions

Previous Reviews on this Version

Gluk41 auto- rejected
Auto-rejected because of new version 10 was uploaded