Review of "Battery Session Timer" version 14

Details Page Preview

Battery session timer with record saving for GNOME Shell

Extension Homepage
https://github.com/Gluk41/battery-session-timer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:581
    file.load_contents(null)
  • extension.js:607
    file.load_contents(null)
  • extension.js:671
    file.load_contents(null)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 9 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:331
    console.warn(`Battery Session Timer: logind недоступен, используется монотонный таймер: ${error}`)
  • extension.js:584
    console.warn(`Battery Session Timer: повреждён файл рекорда ${this._recordFile}`)
  • extension.js:674
    console.warn(`Battery Session Timer: повреждён файл настроек ${this._settingsFile}`)
  • extension.js:173
    console.error(`Battery Session Timer: не удалось подключиться к UPower: ${error}`)
  • extension.js:197
    console.error(`Battery Session Timer: не удалось получить DisplayDevice: ${error}`)
  • extension.js:587
    console.error(`Battery Session Timer: не удалось загрузить рекорд ${this._recordFile}: ${error}`)
  • extension.js:621
    console.error(`Battery Session Timer: не удалось загрузить сессию ${this._sessionFile}: ${error}`)
  • extension.js:677
    console.error(`Battery Session Timer: не удалось загрузить настройки ${this._settingsFile}: ${error}`)
  • extension.js:701
    console.error(`Battery Session Timer: не удалось сохранить ${description} ${path}: ${error}`)

All Versions

Previous Reviews on this Version

Gluk41 auto- rejected
Auto-rejected because of new version 15 was uploaded