Review of "Battery Session Timer" version 12

Details Page Preview

Battery session timer with record saving for GNOME Shell

Extension Homepage
https://github.com/Gluk41/battery-session-timer

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:583
    file.load_contents(null)
  • extension.js:610
    file.load_contents(null)
  • extension.js:676
    file.load_contents(null)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 14 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:227
    console.warn(`Battery Session Timer: ошибка отключения сигнала UPower: ${error}`)
  • extension.js:335
    console.warn(`Battery Session Timer: logind недоступен, используется монотонный таймер: ${error}`)
  • extension.js:365
    console.warn(`Battery Session Timer: ошибка отключения сигнала logind: ${error}`)
  • extension.js:586
    console.warn(`Battery Session Timer: повреждён файл рекорда ${this._recordFile}`)
  • extension.js:666
    console.warn(`Battery Session Timer: не удалось удалить файл сессии ${this._sessionFile}: ${error}`)
  • extension.js:679
    console.warn(`Battery Session Timer: повреждён файл настроек ${this._settingsFile}`)
  • extension.js:260
    console.log(`Battery Session Timer: истекло время сессии (${Math.floor(elapsedSinceSave / 60000000)} мин), заряд изменился на ${chargeDiff}% — сбрасываем сессию`)
  • extension.js:277
    console.log(`Battery Session Timer: заряд изменился на ${chargeDiff}% за короткое время — сбрасываем сессию`)
  • extension.js:173
    console.error(`Battery Session Timer: не удалось подключиться к UPower: ${error}`)
  • extension.js:197
    console.error(`Battery Session Timer: не удалось получить DisplayDevice: ${error}`)

All Versions

Previous Reviews on this Version

Gluk41 auto- rejected
Auto-rejected because of new version 13 was uploaded