Review of "Server Status Indicator" version 65

Details Page Preview

Indicator displaying status of entered web server URLs using emojis.

Extension Homepage
https://github.com/CraigFoote/ca.footeware.gnomeshell.serverstatus.git

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:80
            this.notifsIcon = new St.Icon({
                gicon: this.iconProvider.getNotificationsIcon(true),
                style_class: 'panel-button',
            })
  • extension.js:52
            this.prefsIcon = new St.Icon({
                gicon: this.iconProvider.getPreferencesIcon(),
                style_class: 'panel-button',
            })

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['49', '50', '51']

All Versions

Previous Reviews on this Version

JustPerfection active