Review of "Desktop Icons NG (DING)" version 98

Details Page Preview

Adds icons to the desktop. Fork of the original Desktop Icons extension, with several enhancements .

Extension Homepage
https://gitlab.com/rastersoft/desktop-icons-ng

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • app/askRenamePopup.js
  • app/autoAr.js
  • app/createThumbnail.js
  • app/dbusInterfaces.js
  • app/dbusUtils.js
  • app/desktopGrid.js
  • app/desktopIconItem.js
  • app/desktopIconsIntegration.js
  • app/desktopIconsUtil.js
  • app/desktopManager.js
  • app/desktopMenu.js
  • app/ding.js
  • app/dndClipboardUtils.js
  • app/enums.js
  • app/fileItem.js
  • app/fileItemMenu.js
  • app/fileUtils.js
  • app/menuHelper.js
  • app/notifyX11UnderWayland.js
  • app/preferences.js

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['50', '51']

All Versions

Previous Reviews on this Version

rastersoft posted a review
Please, close this version and review only the next one, which removes the "51" version in the "metadata" file.
JustPerfection rejected
Ok but we approve 51 now since the rc and port guide is out.