Review of "Fresh Web Wallpaper" version 2.1 (11)

Details Page Preview

Fresh, real-world photo wallpapers from Bing, NASA or Peapix, updated automatically — pick a fixed daily source or let it draw randomly from thousands of archived images of these sources, with anti-repetition built in, favourites and banned lists, and a "Today" tab to look back at everything shown since midnight.

Extension Homepage
https://framagit.org/Fred6681/fresh-web-wallpaper

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:2342
                notification.connect('destroy', () => {
                    this._activeNotifications.delete(notification);
                })

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['45', '46', '47', '48', '49', '50', '51']

All Versions

Version Status
2.2 (12) Unreviewed
2.1 (11) Rejected
2.1 (10) Rejected
2.1 (9) Rejected
2.1 (8) Rejected
2.0 (7) Rejected
1.3 (6) Active
1.2 (5) Inactive
1.1 (4) Inactive
1.0 (3) Inactive
1.0 (2) Rejected
1.0 (1) Rejected

Previous Reviews on this Version

Fred6681 posted a review
Hello, This is an update from v1.3 (the last version published). Versions 2.0 and 2.1 were rejected without any stated reason, so I could not tell what needed fixing. This upload therefore contains everything since 1.3, plus new changes. Changes since 1.3: - Favourites / Banned / Today tabs in the preferences, with a per-image heart button, a per-favourite comeback interval, and three draw modes (Normal, Sources only, Favourites only). - JSON export/import of the Favourites and Banned lists (backup). - Current wallpaper thumbnail with title in the menu and preferences. - Improved NASA image detection. - Preferences UI improvements (larger default size, thumbnail spinner, automatic thumbnail regeneration). - Bing archive scraping now starts in May 2023, because image resolution before that date is too inconsistent. - The notification icon is now the wallpaper photo instead of a generic system icon. - Declares compatibility with GNOME Shell 45 to 51. If anything in the code is a problem, please tell me exactly which file or line so I can fix it quickly. Thank you.
JustPerfection rejected
Didn't review. This code seems to be generated by AI. Please note, we have a rule for that: - [EGO Review Guidelines: AI](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-must-not-be-ai-generated) - [Extensions Best Practices Guidelines](https://gjs.guide/extensions/review-guidelines/best-practices.html#submissions-require-maintainership)
Fred6681 posted a review
Ok, thank you for replying to me, but then you could have deleted all the versions. It is very well made and works perfectly, and I spent hours trying to make sure that it is, but it is entirely generated by AI.
JustPerfection posted a review
We accept AI generated extension if you read and understand the code before sending it here. Please read the [Extensions Best Practices Guidelines](https://gjs.guide/extensions/review-guidelines/best-practices.html) if you are willing to make it compatible with EGO.