Review of "Tray Icons: Reloaded" version 2

Details Page Preview

Tray Icons Reloaded is a GNOME Shell extension which bring back Tray Icons to top panel, with additional features.

Extension Homepage
https://github.com/MartinPL/Tray-Icons-Reloaded

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
31 Active
30 Active
29 Active
28 Rejected
27 Active
26 Active
25 Active
24 Rejected
23 Active
22 Active
21 Active
20 Active
19 Active
18 Rejected
17 Active
16 Active
15 Active
14 Active
13 Inactive
12 Inactive
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

andyholmes waiting for author
Can you fix your extension to assign `_settings` to a declared variable or object property, and disconnect the signal handlers when you extension is disabled, please? Signal handlers should likewise be disconnected for other objects you connect to, especially if you're passing functions bound to an object that outlive the emitting object. It took me about 15s to crash the shell by disabling he extension and changing the panel position. If you need help, you can visit #javascript on GNOME or stackoverflow to ask about these concepts.
andyholmes rejected
newer vserion approved