EGO-X-002 warning

extensions should not use synchronous subprocess APIs in shell code

Shell code should avoid synchronous subprocess APIs like `GLib.spawn_command_line_sync()` and `GLib.spawn_sync()`.

Complete Examples

• AppManager.js:45

  GLib.spawn_command_line_sync(`/bin/kill ${pid}`)

• AppManager.js:139

  GLib.spawn_command_line_sync(
  				`/bin/bash -c 'pmap -p ${pid} | grep Qt'`
  			)

• AppManager.js:159

  GLib.spawn_command_line_sync(
  				`/bin/bash -c "pidof -s ${wmclass}"`
  			)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

• schemas/gschemas.compiled

  schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• extension.js:69

  this._settings.connect('changed::icon-brightness', this._setIconEffect.bind(this))

• extension.js:68

  this._settings.connect('changed::icon-contrast', this._setIconEffect.bind(this))

• extension.js:62

  this._settings.connect('changed::icon-margin-horizontal', this._setIconSize.bind(this))

• extension.js:63

  this._settings.connect('changed::icon-margin-vertical', this._setIconSize.bind(this))

• extension.js:65

  this._settings.connect('changed::icon-padding-horizontal', this._setIconSize.bind(this))

• extension.js:64

  this._settings.connect('changed::icon-padding-vertical', this._setIconSize.bind(this))

• extension.js:67

  this._settings.connect('changed::icon-saturation', this._setIconEffect.bind(this))

• extension.js:61

  this._settings.connect('changed::icon-size', this._setIconSize.bind(this))

• extension.js:66

  this._settings.connect('changed::icons-limit',  this._setIconsLimit.bind(this))

• extension.js:58

  this._settings.connect('changed::position-weight', this._setTrayArea.bind(this))

• extension.js:59

  this._settings.connect('changed::tray-margin-left', this._setTrayMargin.bind(this))

• extension.js:60

  this._settings.connect('changed::tray-margin-right', this._setTrayMargin.bind(this))

• extension.js:57

  this._settings.connect('changed::tray-position', this._setTrayArea.bind(this))

• extension.js:15

  this.tray.connect('tray-icon-added', this._onIconAdded.bind(this))

• extension.js:16

  this.tray.connect('tray-icon-removed', this._onIconRemoved.bind(this))