GNOME Shell Extensions

Review of "Tray Icons: Reloaded" version 28

Details Page Preview

Tray Icons: Reloaded

by MartinPL

Tray Icons Reloaded is a GNOME Shell extension which bring back Tray Icons to top panel, with additional features.

Extension Homepage
https://github.com/MartinPL/Tray-Icons-Reloaded
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
31 Active
30 Active
29 Active
28 Rejected
27 Active
26 Active
25 Active
24 Rejected
23 Active
22 Active
21 Active
20 Active
19 Active
18 Rejected
17 Active
16 Active
15 Active
14 Active
13 Inactive
12 Inactive
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove version from Gtk imports. Gtk version has been already specified by the prefs owner. 2. Extensions cannot use `run_dispose()` (line 90 extension.js): > This function should only be called from object system implementations. https://gjs-docs.gnome.org/gobject20~2.0/gobject.object#method-run_dispose Only nulling `this._settings` would be enough. 3. Also null out `this.TrayIcons` in disable: https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects 4. Disconnect the signal on disable (line 79 extension.js): https://gjs.guide/extensions/review-guidelines/review-guidelines.html#disconnect-all-signals 5. You can use `constructor()` instead of `_init()` for gobjects.