Review of "Eruption Profile Switcher" version 16

Details Page Preview

Runtime Profile switcher for the Eruption Realtime RGB LED Driver for Linux

Extension Homepage
https://github.com/eruption-project/eruption-profile-switcher

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Previous Reviews on this Version

JustPerfection rejected
1. Rejected because you should remove timeout on disable() (extension.js line 904). 2. You should only get gsettings object once on enable. Currently getSettings() is called so many times. 3. Use `ExtensionUtils.getSettings()` instead of creating custom function. If you need any help with your extension you can ask us on: GNOME Matrix channel: https://matrix.to/#/#extensions:gnome.org IRC Bridge: irc://irc.gimpnet.org/shell-extensions
X3n0m0rph59 posted a review
Thank you very much for your review, it is much appreciated! I will implement your suggestions an submit a new version.